Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup docs a bit more #127

Merged
merged 1 commit into from
Aug 31, 2016
Merged

cleanup docs a bit more #127

merged 1 commit into from
Aug 31, 2016

Conversation

vchuravy
Copy link
Collaborator

Another round of cleanups.

@codecov-io
Copy link

Current coverage is 65.45% (diff: 100%)

Merging #127 into master will not change coverage

@@             master       #127   diff @@
==========================================
  Files            19         19          
  Lines          1705       1705          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1116       1116          
  Misses          589        589          
  Partials          0          0          

Powered by Codecov. Last update a01a11b...637e378

@pluskid pluskid merged commit abc8ffa into dmlc:master Aug 31, 2016
@vchuravy
Copy link
Collaborator Author

This should fix most of the docs except for JuliaDocs/Documenter.jl#247, JuliaDocs/Documenter.jl#228 and JuliaDocs/Documenter.jl#227

@pluskid can we tag a new release for #126 or do you want to wait on #123?

@vchuravy vchuravy deleted the vc/clean_docs branch August 31, 2016 19:22
@pluskid
Copy link
Member

pluskid commented Aug 31, 2016

Do you know if Julia v0.5 is going to be released soon? If it is very close, we could try to wait for that and try to fix most of 0.5 related warnings before tagging a new version. If is it not going to happen soon, then I'm OK with tagging after #126.

@vchuravy
Copy link
Collaborator Author

The remaining v0.5 warnings are coming from JuliaIO/Formatting.jl#23 and the fact that Compat can't handle Dict([x=>x for x ... ]). The dict issue we can't directly fix until we drop support for v0.4, but it is fairly subdued.

If I would venture a guess v0.5 should be released within the next two weeks, as long as the current RC has no show-stoppers.

@pluskid
Copy link
Member

pluskid commented Aug 31, 2016

Thanks! Sounds good. I think we can make a quick new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants